Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative balance allowed to transfer to piggy bank #818

Closed
AndreiGavriliu opened this issue Sep 8, 2017 · 3 comments
Closed

Negative balance allowed to transfer to piggy bank #818

AndreiGavriliu opened this issue Sep 8, 2017 · 3 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@AndreiGavriliu
Copy link

Negative bank balance allowed to be transferred to piggy bank. See screenshot:

screen shot 2017-09-08 at 13 33 36

@JC5
Copy link
Member

JC5 commented Sep 8, 2017

I could change the display to say "zero", but personally I like to see it when my piggy banks are "overfilled". This could also happen when you create and fill some piggy banks and then empty the account without updating the piggy bank.

@AndreiGavriliu
Copy link
Author

I get your point, and you are right. Also, the logistics behind the empty-account-without-piggy-back-update scenario is a bit overkill, however... the following option should not be available as it does not really make any sense:

“The maximum amount you can add is: €-121.16.“

This happens when trying to add to a piggy-bank from a negative account

@JC5
Copy link
Member

JC5 commented Sep 8, 2017

Ah yes, that is confusing indeed. I'm not sure if it is feasible to calculate that amount beforehand (since each piggy could be linked to a different account this may prove resource-heavy) but the view could certainly be better!

@JC5 JC5 self-assigned this Sep 8, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Sep 8, 2017
@JC5 JC5 closed this as completed in f704ade Sep 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants