Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbolicate stacks inside markers #37

Closed
mstange opened this issue Nov 21, 2016 · 3 comments
Closed

Symbolicate stacks inside markers #37

mstange opened this issue Nov 21, 2016 · 3 comments
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb markers Anything to do with marker data structures, marker chart, or the marker table

Comments

@mstange
Copy link
Contributor

mstange commented Nov 21, 2016

No description provided.

@gregtatum gregtatum added feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb markers Anything to do with marker data structures, marker chart, or the marker table labels Mar 8, 2017
@gregtatum
Copy link
Member

Just double checking since this is so old, but is this still not implemented?

@mstange
Copy link
Contributor Author

mstange commented Mar 8, 2017

It's still not implemented. We also don't show callstacks from inside markers anywhere at the moment. E.g. if you find a "Styles" marker in the markers tab, you'll see that it has a disclosure triangle, but clicking it won't do anything. The old cleopatra would show the marker's call stack under there.

@mstange
Copy link
Contributor Author

mstange commented Apr 3, 2018

Heh, it seems I was confused about how stacks inside markers are represented when I filed this issue. They don't come with their own stack table, they share the stack table with the thread that contains the marker. And that stack table was already being symbolicated. So the symbolication part was never an issue. There was only the issue that we weren't displaying the stack, but this has now been fixed in #756.

@mstange mstange closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Work that is user facing, and typically should be planned through https://airtable.com/shrRydo6UXheb markers Anything to do with marker data structures, marker chart, or the marker table
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstange @gregtatum