Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing URL from /from-addon/ to /public/.../ destroys the world #53

Closed
mstange opened this issue Nov 30, 2016 · 1 comment
Closed

Changing URL from /from-addon/ to /public/.../ destroys the world #53

mstange opened this issue Nov 30, 2016 · 1 comment

Comments

@mstange
Copy link
Contributor

mstange commented Nov 30, 2016

This is because the router replaces ProfileViewerWithDataFromAddon with ProfileViewerWithDataFromWeb due to the URL change. This causes the ProfileSharingCompositeButton to lose its state and to not open the permalink panel. It also causes the call tree tree view to grab focus.
@mstange
Copy link
Contributor Author

mstange commented Dec 5, 2016

Fixed by rewriting URL handling in 977ae15. We no longer use react router.

@mstange mstange closed this as completed Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mstange