New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker and Apps plugin #43
Comments
check it. |
Can't confirm that it works. I've attached some things which might be relevant:
ps auxw doesn-t show -ch being passed to apps.plugin (this might not be needed?)
Last commit with host prefix was included in build. Best, |
There is no Your apps.plugin is not setuid to root, this is why it can only see netdata itself. Do this:
and restart netdata. |
I corrected my response. |
Pretty sure it's fine? |
Seems it is/was fine. Lines are in here if you want to verify: Also from what i understand, apps.plugin should run as root, and it does:
|
It seems it might be a docker issue, investigating. |
Yes, running docker container has to have |
If you can, please open http://cdn.si:19999 if you see anything out of place (missing data/charts, something that could be caused by the isolated docker environment). If everything looks good, let's close this issue :) Sorry for so many comments. |
Without the SYS_PTRACE capability, the environment variables don't get passed from the netdata daemon, to the apps.plugin and other plugins. In this case it means that apps.plugin is reading info from Can we pass this as an argument, or as part of the exec call itself (AAA=xxx ./apps.plugin?). I know it's not ideal, but it would drop the need for |
Where do you add SYS_PTRACE? Is it something I can add to netdata? |
No, SYS_PTRACE is a capability that needs to be enabled on the docker Without it, I couldn't print the environment from a process (even as root). But, I think netdata can be modified slightly, so this capability is not On Mon, Jan 11, 2016 at 6:56 PM, Costa Tsaousis notifications@github.com
|
Well, this does not sound right to me. Environment variables between the same process tree in the same docker should not be affected by anything else. I have added a log line.
Mine logs this:
I have not set it, so it found it empty. Which one does yours log? |
I updated the docker image with the new netdata code, and ran the container without --cap-add. It seems you were correct, the environment is passed to apps.plugin. It also seems the --cap-add switch is here to stay:
So, to amend my theory, it seems the mapped proc filesystem is not readable without SYS_PTRACE. Closing the issue, thanks for everything. |
* httpcheck charts fix * httpcheck wip * httpcheck wip * HttpCheck => HTTPCheck * HttpCheck => HTTPCheck * HTTPCheck some tests * minor
The Apps section of netdata doesn't give correct output when run with docker. Only "netdata" process is graphed. The process is run with -ch /host, data is mapped to container:
It seems the basic problem is that apps.plugin doesn't support -ch prefix yet?
Opening apps_plugin.c confirms this:
The text was updated successfully, but these errors were encountered: