New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing build on FreeBSD #187
Conversation
ok, that seems easy! |
Still need to test it, I have to study the installer or set up a jail for it, i would like to keep my system clean... i hope i find enough time to port it. |
ok, if you install it in |
I'll keep this unmerged, until you feel you have reached some point that can be shared. ok? |
With the above patches and some tweaking on the installer switch (use gmake instead of make, use /usr/bin/env bash instead of /bin/bash) I can start it on FreeBSD 10.3. |
nice work! |
@ktsaou Would you be interested in patches to allow netdata to use sysctl on FreeBSD? Generally we use #ifdefs to do something like that. |
Yes of course! Please do so! Keep in mind they not need to be You can copy Also, copy Then we could choose the right files at To have the same "look and feel", the chart and dimension names could be the same. This will allow the dashboard (javascript code) to work seamlessly. But don't be too strict either. If you write the core data collection for freebsd, the whole idea is to give a powerful tool to replace the console - not to "emulate the linux world closely". So a balance is needed. Not totally different (too much work for all of us), not exactly the same (not that much value for the users). |
About plugin_freebsd.c, I will try to keep #ifdefs at minimum, but still keeping the code as close to the original, i dont want to have a separate file as i dont want to keep on merging the changes from linux version to another file. If major changes are needed, sure, i will create a separate implementation but as long as changes on build are trivial, i will keep it in the same file. larsengels: thank you for your feedback :) |
Ok, good. Keep in mind though, that if data are exposed from the BSD kernel in completely different groups/collections, you may end up with unmanageable code (my guess is that you will have even different dimensions in several cases). If the whole thing is Anyway, your call. Do as you see fit. Just remember to keep the chart and dimension ids/names as close as possible to the Linux ones, to minimize the complexity on the UI. Feel free to add charts, feel free to remove charts, but if they overlap try to inherit the Linux ids/names. |
This is promising, I'd like to run this on my freenas setup |
Is there any chance that this will be pushed forward and netdata will be ported to FreeBSD? |
I think @roker is working on it. |
Sounds great! |
I would also love to run this on my freenas setup. Looking forward to it! |
any new progress on this? would really like to see FreeBSD support added. 👍 |
I suggest closing this PR since FreeBSD is already supported by |
You are right! |
Amazing! |
I have changed a few details to compile netdata on freebsd 10.3.