Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arrow aggrigator #17

Merged
merged 7 commits into from Dec 29, 2023
Merged

Feature/arrow aggrigator #17

merged 7 commits into from Dec 29, 2023

Conversation

Ignalina
Copy link
Contributor

Would be good to have this in main so we dont diverge to much.

improved:
made CLAP use 3 subcomands mock,slice,parse
Partial impl of parse.

bad news:
No unit test

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (3ed5a73) 33.28% compared to head (8070db7) 31.55%.

Files Patch % Lines
src/builder_datatypes.rs 0.00% 48 Missing ⚠️
src/main.rs 0.00% 45 Missing ⚠️
src/builder.rs 0.00% 16 Missing ⚠️
src/mock.rs 0.00% 4 Missing ⚠️
src/slicer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   33.28%   31.55%   -1.73%     
==========================================
  Files           5        7       +2     
  Lines         712      751      +39     
==========================================
  Hits          237      237              
- Misses        475      514      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilhelmagren wilhelmagren merged commit d075b6e into main Dec 29, 2023
9 checks passed
@wilhelmagren wilhelmagren deleted the feature/arrow_aggrigator branch December 29, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants