Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connlib: how to handle overlapping IP ranges of CIDR resources? #4694

Closed
thomaseizinger opened this issue Apr 19, 2024 · 0 comments
Closed

Comments

@thomaseizinger
Copy link
Member

As part of #4597, I discovered that it is currently possible to add CIDR resources with overlapping IP ranges. We currently use longest_match to select, which resource the user wants to access based on an incoming IP packet.

I don't know if this is intentional or not and I am not sure which resource "wins" here (I think the one that got added first?). I've not been involved in the design decisions here but I think we should disallow overlapping IP ranges.

@thomaseizinger thomaseizinger changed the title connlib: how to handle overlapping IP ranges? connlib: how to handle overlapping IP ranges of CIDR resources? Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant