Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check code formatting in CI #25

Open
izqui opened this issue Aug 18, 2022 · 2 comments
Open

Check code formatting in CI #25

izqui opened this issue Aug 18, 2022 · 2 comments

Comments

@izqui
Copy link
Member

izqui commented Aug 18, 2022

Once forge fmt is stable, we should run forge fmt --check in CI to make sure code style stays consistent
@Evalir
Copy link
Contributor

Evalir commented Feb 28, 2023 •
edited

Wondering if this is still relevant? Happy to send in a PR if so—forge fmt is already stable and recommended.

I also ran forge fmt --check against the repo and saw there's quite a diff already. Happy to also send in a PR applying forge fmt.

@izqui
Copy link
Member Author

izqui commented Mar 1, 2023

That would be nice indeed!

Yea we forgot to run forge fmt before releasing unfortunately

@Evalir Evalir mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI, Contracts: Add forge fmt --check to CI, run forge fmt Evalir/firm-protocol
2 participants
@izqui @Evalir