Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include or don't include an http request implementation #8

Open
a-s-o opened this issue Feb 16, 2016 · 5 comments
Open

Include or don't include an http request implementation #8

a-s-o opened this issue Feb 16, 2016 · 5 comments

Comments

@a-s-o
Copy link

a-s-o commented Feb 16, 2016

Alternatives:

  • superagent (currently used in tutorials)
  • axios (similar to angular $http)
  • request
  • fetch API polyfill

Why:

  • if an implementation is included, then we can create helpers/standardized api for async actions
@a-s-o a-s-o added this to the 0.9 - almost big milestone Feb 16, 2016
@SeeThruHead
Copy link

fetch with the option to swap out for other promise based http libs?

@a-s-o
Copy link
Author

a-s-o commented Feb 16, 2016

Sure, but then there is a need to also include a promise polyfill at least for a little while. I don't mind that but in that case, I would like to see if that is not a turn off for people.

I will start looking at some alternatives and see how much they change the build size.

@SeeThruHead
Copy link

I think any http lib that people might want to use in a modern stack is promise based.

@a-s-o
Copy link
Author

a-s-o commented Feb 16, 2016

Agreed; I hardly work without them now. So, I take it you are in the include an http lib camp instead of leaving it as a user decision.

BTW I am leaning towards your direction but just a bit indecisive. Thanks for your input.

@SeeThruHead
Copy link

Yeah I would opt for making this as user friendly as possible. That means setting sane defaults for most (maybe all?) basic features like http requests. I do however think that you should be able to supply your own http lib / promise polyfill as an override. Just my 2cents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants