Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to changed file has commit sha instead of branch name in its URL #135

Closed
gr2m opened this issue Sep 27, 2017 · 9 comments
Closed

link to changed file has commit sha instead of branch name in its URL #135

gr2m opened this issue Sep 27, 2017 · 9 comments

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 27, 2017

for example in this issue: gr2m/initials#32

the link behind README.md in step 3 linked to https://github.com/gr2m/initials/blob/d5bccfe96675007a562360bb2e2c48c4a50d7f92/README.md which doesn’t work, because in order for the edit button to work, the link must use a branch name instead. The correct link is https://github.com/gr2m/initials/blob/master/README.md

@Techforchange
Copy link
Contributor

Claiming this :)

@RaiVaibhav
Copy link

Sir i did't get problem does i have to change the link???i did't get it or its is a tutorial

@RaiVaibhav
Copy link

RaiVaibhav commented Sep 27, 2017

@Techforchange i am new so no idea

@Techforchange
Copy link
Contributor

@RaiVaibhav No worries! I'm currently working on this issue but feel free to grab one of the other issues. All your help is greatly appreciated :) Let me know if you have any questions!

@RaiVaibhav
Copy link

RaiVaibhav commented Sep 27, 2017

Ok No Problem But what exactly we have to do here @Techforchange i did't understand the question
Any help would be appriciated

@RaiVaibhav
Copy link

@gr2m can you please help?

@gr2m
Copy link
Contributor Author

gr2m commented Sep 27, 2017

@RaiVaibhav did you get here via gr2m/initials#32? This is an entirely different project here :)

This issue is not a good first issue to work on if you don’t yet know how first-timers-bot works. There are other issues that are better suited

@RaiVaibhav
Copy link

@gr2m Yes i go through the link gr2m/initials#32, and i also get that we have to change the link of readme.md as edit button will not work , i have taken it in wrong sense like edit in documentation soory my bad

@RaiVaibhav
Copy link

ok i got it whoever is claiming have to solve the issue and we have to change the link of bot
Thanks @gr2m for helping me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants