Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the message creation and send methods #3844

Closed
slavkoja opened this issue Apr 11, 2021 · 4 comments
Closed

Separate the message creation and send methods #3844

slavkoja opened this issue Apr 11, 2021 · 4 comments

Comments

@slavkoja
Copy link

Please, can you separate the email message creation and send methods, to one can only override the message creation or use it to get message and then customize values and use built-in send (and transport).

I meet this in reminder module, where i want to add the List-Unsubscribe header...

@fisharebest
Copy link
Owner

You want to add the header to all emails - or just some emails?

@slavkoja
Copy link
Author

For all messages, i didn't play with it, it is only idea yet.

My PHP knowledge/skill are limited, but on quick look into send() method i see, that for now i need to do whole send() method by own, if i need to modify message. My idea is, that separating them i can choose to create whole message by own, or use webtree's method and modify the result only (add header), and then send it by built-in way.

@fisharebest
Copy link
Owner

What action do you take when you receive the unsubscribe link?

Update the user's account to change the "contact method" to stop sending mail?

@slavkoja
Copy link
Author

No one-click unsubscribe, only link to webtrees's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants