New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ModuleThemeInterface::parameters #4070
Comments
Is there any chance to restore some flexibility in the choice of colours that were associated with the removed parameters? In 34b20f2, all those parameters have been replaced by hardcoded values, but not all themes (even amongst the standard ones, most notably the Minimal theme) were using the same colour palette for the chart-background-* and distribution-chart-* as those hardcoded ones. I have been using specific colours in the Rural theme as well. What bother me a bit is that:
I have tried playing with CSS on the Google Charts, but there are not enough selector available to override the default colour. |
We need these colours for the fan-chart and the google-charts. Both need to be replaced. The fan-chart needs to replace PNG with SVG. We will be able to style this using the theme's CSS. The google-charts need to be replaced completely. See #3883 If you want to suggest more neutral colours that will work with a wide range of themes, then please do. |
If there are plans to replace those charts, with alternatives that will allow to use the CSS styling , then I am happy to wait, and temporarily fall back to default colours for the time being. |
This was legacy code from webtrees 1.
Most of the parameters have been replaced with CSS.
The rest need to be removed too.
The text was updated successfully, but these errors were encountered: