Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice required on creation of new News / Journal module #78

Closed
ddrury opened this issue Jan 16, 2014 · 0 comments
Closed

Advice required on creation of new News / Journal module #78

ddrury opened this issue Jan 16, 2014 · 0 comments

Comments

@ddrury
Copy link
Contributor

ddrury commented Jan 16, 2014

Hi Greg,

I've created a new module to replace the current gedcom_news and user_blog modules, it uses another new module (markitup) that uses markdown for editing in a modal dialog, it also adds the ability to assign permitted languages to each article.

So far so good, however I'm finding potential knock on effects and am wondering whether it's worth duplicating some code in the module to keep it self contained or change core code.

Examples ..
There are currently functions getUserNews & getGedcomNews in authentication.php. It is trivial to convert these to a single getNews function which I've done, however library/WT/stats.php calls the old functions (BTW there is a bug here checkout line 3687 of stats.php) which would also be simple to change.

Do I put CSS in the theme or keep it local.

To accommodate the language selection the news table needs an additional column

The more I do the further I diverge from the existing news/journal modules so if there's no chance of you adopting this, I'll stop now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant