Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(bones_ecs)!: require systems to impl Sync. #20

Closed
wants to merge 1 commit into from

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Jan 1, 2023

This makes things easier when integrating with Bevy right now.
If this becomes too restrictive in the future we can re-visit.

BREAKING_CHANGE: Systems must now implement Sync in addition to the previous trait bounds.

This makes things easier when integrating with Bevy right now.
If this becomes too restrictive in the future we can re-visit.

BREAKING_CHANGE: Systems must now implement `Sync` in addition to the previous trait bounds.
@zicklag
Copy link
Member Author

zicklag commented Jan 1, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jan 1, 2023
This makes things easier when integrating with Bevy right now. If this becomes too restrictive in the future we can re-visit.

BREAKING_CHANGE: Systems must now implement `Sync` in addition to the previous trait bounds.
@bors
Copy link
Contributor

bors bot commented Jan 1, 2023

Build failed:

@zicklag
Copy link
Member Author

zicklag commented Jan 1, 2023

bors retry

bors bot pushed a commit that referenced this pull request Jan 1, 2023
This makes things easier when integrating with Bevy right now.
If this becomes too restrictive in the future we can re-visit.

BREAKING_CHANGE: Systems must now implement `Sync` in addition to the previous trait bounds.
@bors
Copy link
Contributor

bors bot commented Jan 1, 2023

Pull request successfully merged into main.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat(bones_ecs)!: require systems to impl Sync. [Merged by Bors] - feat(bones_ecs)!: require systems to impl Sync. Jan 1, 2023
@bors bors bot closed this Jan 1, 2023
@zicklag zicklag deleted the feat/sync-systems branch January 1, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant