Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Switch back to panic=unwind #26

Open
geofft opened this issue May 27, 2018 · 0 comments
Open

Switch back to panic=unwind #26

geofft opened this issue May 27, 2018 · 0 comments

Comments

@geofft
Copy link
Collaborator

geofft commented May 27, 2018

I think we need to unwind when we panic so we appropriately drop things, poison mutexes, etc. I don't really know how to integrate with the kernel's unwinder: the challenge is we need to unwind every Rust function on the stack, even if there's C code in between, but not unwind past the end of the stack. (I'm also not sure the kernel has a meaningful unwinder.) We'll need to define an appropriate / meaningful eh_personality lang item, see comments in src/libpanic_unwind/gcc.rs for details and an example.

Or, I can be convinced that not dropping things and leaving mutexes locked is sound. (Seems suboptimal though)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant