Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errant uses of safe_cast #113

Merged
merged 1 commit into from Jan 10, 2019
Merged

fix errant uses of safe_cast #113

merged 1 commit into from Jan 10, 2019

Conversation

drewbanin
Copy link
Contributor

  • do not use safe_cast when inappropriate (see here) (union_tables, unpivot)
  • improve union_tables integration test
  • fix union_tables for Snowflake
  • add unpivot integration test -- this was disabled before, which was terrible

Note that this changes the behavior of unpivot slightly. Duplicate column names with different casing are no longer permitted, but I think that's a fair assumption to make.

@drewbanin drewbanin mentioned this pull request Jan 10, 2019
Copy link
Member

@jthandy jthandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice--this is great. I'm all for it.

I should really add some documentation around safe_cast and its intended usage. I kind of doubt I'll get to that soon but it would be good to avoid this same misunderstanding down the road.

:shipit:

@drewbanin drewbanin merged commit eeea5cc into master Jan 10, 2019
@drewbanin drewbanin deleted the fix/cast-in-union-tables branch January 10, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants