Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't rely on master branch for latest version number #1122

Closed
drewbanin opened this issue Nov 14, 2018 · 0 comments
Closed

don't rely on master branch for latest version number #1122

drewbanin opened this issue Nov 14, 2018 · 0 comments
Labels
enhancement New feature or request
Milestone
Grace Kelly

Comments

@drewbanin
Copy link
Contributor

drewbanin commented Nov 14, 2018 •
edited

Feature

Feature description

The master branch of dbt isn't really a thing anymore. Instead of relying on the master branch to grab the latest release number, we should pull it from PyPi.

We can use this api to fetch some JSON info about dbt releases.

We need to confirm that pre-releases are not shown as the latest version for a package on PyPi.

Who will this benefit?

dbt maintainers :)
@drewbanin drewbanin added the enhancement New feature or request label Nov 14, 2018
@drewbanin drewbanin added this to the Grace Kelly milestone Nov 14, 2018
@beckjake beckjake mentioned this issue Dec 5, 2018
Merged
beckjake added a commit that referenced this issue Dec 5, 2018
@beckjake
Merge pull request #1174 from fishtown-analytics/feature/latest-versi…
bec30ef 
…on-from-pypi

use pypi for the latest version instead of git [#1122]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Grace Kelly
Development

No branches or pull requests
1 participant
@drewbanin