Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _dbt_internal_test subquery alias #3398

Closed
jtcohen6 opened this issue May 26, 2021 · 1 comment · Fixed by #3414
Closed

Rename _dbt_internal_test subquery alias #3398

jtcohen6 opened this issue May 26, 2021 · 1 comment · Fixed by #3414
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jtcohen6
Copy link
Contributor

Let's rename _dbt_internal_test here:

https://github.com/fishtown-analytics/dbt/blob/0f018ea5dd678d37668c819552328b3254c2f220/core/dbt/include/global_project/macros/materializations/test.sql#L4-L7

So that it doesn't start with an underscore. Believe it or not, this is a deal-breaker for some SQL syntaxes.

@jtcohen6 jtcohen6 added the bug Something isn't working label May 26, 2021
@jtcohen6 jtcohen6 added this to the Margaret Mead milestone May 26, 2021
@vijaybalebail
Copy link

for Oracle , Nonquoted identifiers must begin with an alphabetic character from your database character set. Quoted identifiers can begin with any character.. Its recomended not to start with a _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants