New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline around SQL in incremental materialization to guard against line comments. #1019

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@elexisvenator
Copy link
Contributor

elexisvenator commented Sep 20, 2018

Prevents syntax errors when the last line of a model is a line comment.

@drewbanin drewbanin self-requested a review Sep 20, 2018

@drewbanin

This comment has been minimized.

Copy link
Contributor

drewbanin commented Sep 20, 2018

Thanks @elexisvenator! This PR fixes #1018

@drewbanin drewbanin changed the base branch from master to dev/guion-bluford Sep 20, 2018

@drewbanin drewbanin merged commit 5b94bc3 into fishtown-analytics:dev/guion-bluford Sep 20, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment