re-add --warn-error flag #1347
Merged
re-add --warn-error flag #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was lost in the merge+rebase madness that happened during source freshness' merging. Git bisect is actually very confused about this and tells me that there are no commits where the change happens... I've got a commit where it was added, and one where it was removed, and I can't figure out where it happened in between. Everything looks fine with this now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beckjake I'm a little worried this got lost in a merge somehow? It was merged over here but it's not currently present in
main.py. Is there a good way to figure out where we lost it (and if we lost anything else?)