snapshot config blocks (#1613) #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshots can now be configured via {{ config(...) }}
Added tests that exercise that
drewbanin
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Cool, this looks great! Really amazing that it's +110 LOC including tests.
I left one comment here about snapshot pre/post hooks. I think those will be a good thing to support, and I think we only need to change one materialization file. Let me know what you think about that.
| @@ -23,7 +23,7 @@ def _is_hook_or_model_vars_path(keypath): | |||
| if first in {'on-run-start', 'on-run-end'}: | |||
| return True | |||
| # models have two things to avoid | |||
| if first in {'seeds', 'models'}: | |||
| if first in {'seeds', 'models', 'snapshots'}: | |||
There was a problem hiding this comment.
we should probably add support for pre- and post- hooks in snapshots here
drewbanin
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1613
Snapshots can now be configured via {{ config(...) }}
Added tests to exercise it