Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setuptools version check for overall setup.py #2076

Merged
merged 1 commit into from Jan 29, 2020

Conversation

markberger
Copy link

Checks version of setuptools in the overall setup.py for unicode support similar to setup.py in dbt-core: https://github.com/fishtown-analytics/dbt/blob/dev/0.15.1/core/setup.py#L6

This addresses #1771

@cla-bot
Copy link

cla-bot bot commented Jan 29, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @markberger

@drewbanin
Copy link
Contributor

Thanks for opening this PR @markberger! I just kicked off the tests here - let me know if you're able to sign the CLA and then we can get this merged for dbt v0.15.2 :D

@markberger
Copy link
Author

Thanks Drew! I signed the CLA after opening this pr but it looks like the bot did not recognize that. Is there anything else I need to do?

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's unfortunate that we do a useless find_namespace_packages import, but I think it's better that all setup.py files test the version the same way.

@drewbanin
Copy link
Contributor

@cla-bot check

Thanks @markberger - this will go out for v0.15.2 :D

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2020
@cla-bot
Copy link

cla-bot bot commented Jan 29, 2020

The cla-bot has been summoned, and re-checked this pull request!

@drewbanin drewbanin merged commit bd5e6bd into dbt-labs:dev/0.15.2 Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants