Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error in error handler for duped data tests #2407

Merged
merged 1 commit into from May 6, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented May 6, 2020

resolves #2406

Description

If a resource type is duped but not ref-able, use a placeholder value in the error message. This message is probably incorrect/unnecessary for data tests today, and we should consider allowing data tests with duplicate names in the future.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 6, 2020
@drewbanin drewbanin force-pushed the fix/dupe-resource-type-error branch from e36e60b to fb5320f Compare May 6, 2020 14:11
@drewbanin drewbanin requested a review from beckjake May 6, 2020 14:11
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Yeah, duplicate test names in a single project are a problem because tests live in the manifests and need to have unique IDs (because they participate in the graph). But duplicates across projects should really be fine.

@drewbanin drewbanin merged commit d01c161 into dev/octavius-catto May 6, 2020
@drewbanin drewbanin deleted the fix/dupe-resource-type-error branch May 6, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running dbt with a duplicate test name gives an unhelpful error
2 participants