alias for schema tests macros #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
May 7, 2020
There was a problem hiding this comment.
Looks great - thanks @mikaelene! I just kicked off the tests - will happily merge this when they pass :)
One more thing though: can you add an entry to the CHANGELOG.md file and add yourself as a contributor for the 0.17.0 release? Thanks!
|
FYI I also cooked up this issue so that you could override the core schema tests in |
|
Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2397
Description
Added aliases to columns returned from schema_tests macros. This will make the macros work on adapters required columnnames in their driver such as dbt-sqlserver with it's pyodbc driver
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.