Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the default scopes to the default BigQuery credentials #3041

Merged
merged 1 commit into from Mar 24, 2021

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jan 29, 2021

resolves #3040

Description

We have to pass the scope to access BigQuery tables whose data sources are google spreadsheets on Google Drive.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2021
@yu-iskw yu-iskw marked this pull request as ready for review January 29, 2021 09:50
@jtcohen6 jtcohen6 changed the base branch from dev/margaret-mead to develop February 8, 2021 11:28
@jtcohen6
Copy link
Contributor

Ok! Now that we finally understand the cause of #3040, and confirmed that this change resolves the issue, let's move ahead with it.

@yu-iskw Could I ask you to merge/rebase the changes in develop, add a Changelog entry until v0.19.1 - Fixes, and add yourself to the list of Contributors there?

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of getting this fix into v0.19.1, with a timely second release candidate (and final release), I'm going to go ahead and merge this as-is, with the Changelog entry to come after.

Thanks so much for the contribution @yu-iskw!

@jtcohen6 jtcohen6 merged commit 440a5e4 into dbt-labs:develop Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access BigQuery tables whose original sources are spreadsheets on Google Drive with the oauth method
2 participants