Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Umm al-Qura calendar support #5

Open
ddohler opened this issue Jun 10, 2016 · 5 comments
Open

Add Umm al-Qura calendar support #5

ddohler opened this issue Jun 10, 2016 · 5 comments

Comments

@ddohler
Copy link

ddohler commented Jun 10, 2016

This is an Islamic calendar used in Saudi Arabia, and it gives dates that are sometimes a day offset from the Islamic calendar calculations in this library.
https://github.com/tytkal/python-hijiri-ummalqura

@fitnr
Copy link
Owner

fitnr commented Jun 11, 2016

If that library is working, I'll mark this as "nice to have, not a priority".

@ddohler
Copy link
Author

ddohler commented Jun 11, 2016

It works as far as I've tested it; it would be nice to have together in one library with other calendars, but the other library should be workable for our use case for now since Umm al-Qura is the only non-Gregorian calendar we need to support at the moment.

In the (probably unlikely) event that we have time for implementation, would you accept a pull request for equivalent functionality here?

@feenes

This comment has been minimized.

@fitnr
Copy link
Owner

fitnr commented May 10, 2020

@feenes It has not been merged. The item above your comment refers to a different library.

@snoopyjc
Copy link

I'd like to see this support too, in order to match the [$-1170401] number format of Excel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants