Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transformer to be compatible with idn-area-data v3 #29

Closed
fityannugroho opened this issue Sep 18, 2023 · 0 comments · Fixed by #30
Closed

Update transformer to be compatible with idn-area-data v3 #29

fityannugroho opened this issue Sep 18, 2023 · 0 comments · Fixed by #30
Labels
enhancement New feature or request
Milestone
v0.4.0

Comments

@fityannugroho
Copy link
Owner

Is your feature request related to a problem? Please describe

Describe the solution you'd like

The transformers (RegencyTransformer, DistrictTransformer, VillageTransformer, and IslandTransformer) need to be updated by removing .replace(/\./g, '') from code property.

Describe alternatives you've considered

None

Additional context

None
@fityannugroho fityannugroho added the enhancement New feature or request label Sep 18, 2023
@fityannugroho fityannugroho added this to the v0.4.0 milestone Sep 18, 2023
@fityannugroho fityannugroho mentioned this issue Sep 18, 2023
Merged
9 tasks
@fityannugroho fityannugroho linked a pull request Sep 18, 2023 that will close this issue
feat: add dots in code data #30
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

feat: add dots in code data fityannugroho/idn-area-extractor
1 participant
@fityannugroho