Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo miri test --features collections fails #164

Closed
konsumlamm opened this issue Jun 23, 2022 · 1 comment · Fixed by #168
Closed

cargo miri test --features collections fails #164

konsumlamm opened this issue Jun 23, 2022 · 1 comment · Fixed by #168

Comments

@konsumlamm
Copy link
Contributor

Currently, the CI only runs Miri without any features enabled. When I tried to enable all features, I got an "Undefined Behavior" error, see https://github.com/fitzgen/bumpalo/runs/7022998455?check_suite_focus=true.
@fitzgen
Copy link
Owner

fitzgen commented Jun 23, 2022

Not sure it is worth fixing this old forked std code. Would probably be better to either

  • Update to new forked std code, which presumably has been fixed and runs green under MIRI, or
  • wait for custom allocators to stabilize in std and delete the collections submodule.

@konsumlamm konsumlamm mentioned this issue Jun 24, 2022
Merged
@zetanumbers zetanumbers mentioned this issue Jun 27, 2022
Merged
4 tasks
@konsumlamm konsumlamm mentioned this issue Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cargo miri test --all-features zetanumbers/bumpalo
2 participants
@fitzgen @konsumlamm