Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Databricks Compatibility #34

Closed
1 of 4 tasks
fivetran-catfritz opened this issue May 10, 2023 · 0 comments · Fixed by #33
Closed
1 of 4 tasks

[Feature] Databricks Compatibility #34

fivetran-catfritz opened this issue May 10, 2023 · 0 comments · Fixed by #33
Assignees
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented May 10, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

For Databricks Compatibility, add the following:

  1. Buildkite testing:
    • Update pre-command (example)
    • Update pipeline.yml (example)
    • Update sample.profiles.yml (example)
    • Add the below to integration_tests/dbt_project.yml if it's not there:
dispatch:
  - macro_namespace: dbt_utils
    search_order: ['spark_utils', 'dbt_utils']
  1. For source packages, update src yml so a database won't be passed to spark (example or use below):
sources: 
  - name: <name>
    database: "{% if target.type != 'spark' %}{{ var('<name>_database', target.database) }}{% endif %}"
  1. Update any incremental models to update partition_by for databricks and add current strategies if not present:
config(
        materialized='incremental',
        unique_key='<original unique key>',
        partition_by={'field': '<original field>', 'data_type': '<original data type>'} if target.type not in ('spark','databricks') else ['<original field>'],
        incremental_strategy = 'merge' if target.type not in ('postgres', 'redshift') else 'delete+insert',
        file_format = 'delta' 
)

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz self-assigned this May 10, 2023
@fivetran-catfritz fivetran-catfritz added type:enhancement New functionality or enhancement priority:p3 Affects many users; can wait status:in_review Currently in review update_type:feature Primary focus is to add new functionality labels May 10, 2023
@fivetran-catfritz fivetran-catfritz linked a pull request May 10, 2023 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant