Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Please add Netsuite2 pass-through column support for job object #101

Open
2 of 4 tasks
wardw123 opened this issue Dec 22, 2023 · 2 comments
Open
2 of 4 tasks

Comments

@wardw123
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Please add Netsuite2 pass-through column support for job object, similar to the pass through functionality for other netsuite_source objects. Thanks!

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@wardw123
Copy link
Author

wardw123 commented Dec 22, 2023

If it helps, I mocked up a new version of the stg_netsuite2__jobs.sql file as well as the get_job_columns.yml macro that I believe does the trick! Files are attached in a zip file. It seemed to do the trick without breaking anything!

Netsuite Jobs with passthrough.zip

Screen Shot 2023-12-21 at 5 24 48 PM

@fivetran-avinash fivetran-avinash added type:enhancement New functionality or enhancement status:scoping Currently being scoped update_type:feature Primary focus is to add new functionality and removed type:enhancement New functionality or enhancement status:scoping Currently being scoped update_type:feature Primary focus is to add new functionality labels Dec 26, 2023
@fivetran-avinash
Copy link
Contributor

fivetran-avinash commented Dec 26, 2023

Hi @wardw123! Thanks for investigating the best approach here. I took a look and it seems like that your approach would be the best way to get passthrough columns into the job object.

If you are able to open a PR on the dbt_netsuite_source package with these changes, we can take a look, approve it, and get it ready to merge. Make sure you complete all the steps in the pull request template form (it should show up once you've pushed your branch) before submitting. Let us know if you have questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants