Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Add support for the detail_type field for Inventory Lines #27

Closed
fivetran-joemarkiewicz opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Are you a Fivetran customer?

Fivetran identified feature request

Is your feature request related to a problem? Please describe.

The package currently has some involved where clauses within the int_quickbooks__invoice_double_entry model to filter out invoice subtotals and shipping costs.

where coalesce(invoice_lines.account_id, invoice_lines.sales_item_account_id, invoice_lines.sales_item_item_id, invoice_lines.item_id) is not null

While this logic does work, the connector now syncs the detail_type field that highlights if the field is a subtotal. The package would benefit from just filtering on this field opposed to a long coalesce argument to check for subtotals.

Describe the solution you'd like

The int_quickbooks__invoice_double_entry leverages the new detail_type field to filter out invoice line subtotals.

Describe alternatives you've considered

The current solution is the alternative which would be preferred to remove in favor of referencing the detail_type field.

Additional context

The detail_type field was recently added and would need to require a historical resync for users if they would like the new logic to work properly. This would mean the proposed feature request would result in a breaking change.

@fivetran-joemarkiewicz
Copy link
Contributor Author

Closing this issue as it is now leveraged in the latest release via the above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant