Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When MIME type of content rendered is "application/json" @context shall not be rendered #17

Closed
jmcanterafonseca opened this issue Nov 21, 2018 · 3 comments
Assignees
Labels

Comments

@jmcanterafonseca
Copy link

instead a JSON-LD Link header shall be provided as part of the HTTP response

@jmcanterafonseca
Copy link
Author

the test on #18 shows that this issue remains

@kzangeli
Copy link
Collaborator

I added one more functest to cover the issue about context in payload/header depending on the Accept header.
What can I say, it seems to be working just fine.

I did get an error in "core context" and not "default context" though.
Curiously enough, this error only occurs when the context is in the payload, not when the context is in the http header (Link) ...

Will deal with this later (issue #18), not relevant for this issue.

See the functests:

  • ngsild_context_in_header_or_payload_when_entity_has_no_context.test
  • ngsild_context_in_header_or_payload_when_entity_has_a_context.test

visible starting from the branch task/65.one-more-functest-for-context-inhttp-header-vs-payload

@jmcanterafonseca
Copy link
Author

still happening on ed9be30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants