Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Promise Rejection / Retry #4

Open
renegare opened this issue Nov 25, 2014 · 5 comments
Open

Question: Promise Rejection / Retry #4

renegare opened this issue Nov 25, 2014 · 5 comments
Milestone

Comments

@renegare
Copy link

When a promised module is rejected. If another (or the same) calling module requests the promised module, definejs request the module again or automatically reject the call based on the first on the first rejection (sorry for the confusion)?

@mehranhatami
Copy link
Member

@renegare not at all. The point is, at the moment this question is the main open issue in DefineJS. You will see the answer in one of examples soon.

@renegare
Copy link
Author

Ha! Just more examples ... cool look forward to seeing some. I will be using your lib in some prototypes and let you know too.

@mehranhatami mehranhatami added this to the 1.0.0 milestone Dec 13, 2014
@mehranhatami
Copy link
Member

Promised modules are like:

define([ /*'dependency'*/ ], function ( /*dependency*/ ) {
  return new Promise(function (fulfill, reject) {
    //fulfill when succeeded and pass the fulfillment value  
    //otherwise your module definition gets rejected
  });
});

And they still need more discussion and real world feedbacks for their rejection state. This issue will be open to discuss all the possible feedbacks around it. Feel free to bring up your views regarding the rejection state of promised modules and the way you would prefer to handle your modules definitions when they get rejected.

@wzs28150
Copy link

wzs28150 commented May 3, 2017

image
How to solve the JS merger is still loading the corresponding JS file?

@mehranhatami
Copy link
Member

@wzs28150 I don't think I can reproduce the same exact issue. Can please you give me a code snippet to investigate your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants