Mark generated classes as generated #116

[Serranya]

@jjlauer this is my initial attempt at #116.

I haven't made the feature configurable yet, because there is something I want to discuss first.

My intention was to apply the annotation to every class rocker generates. The catch is, that rocker generates:

• anonymous classes for java 6 and 7
• lambas for java 8

Right now java does not allow annotations on either of them.

For anonymous classes there might be a solution in the form of JSR308 (Introduced in java 8).

callMethod(new @Generated AnonymousClass(){})

But this also has it's problems:

1. I don't think JaCoCo supports JSR308 annotations.
2. This only works for anonymous classes. Those are only generated by rocker on the <8 java profile. But JSR308 requires at least java 8.

Those are the options we have in the order my preference:

0: Promote the anonymous classes and lambdas to proper classes
Let's generate the problematic classes as static inner classes that can be annotated.

Pros:

• Only rocker code changes required.
• Completely solves the problem. JaCoCo works now.

Cons:

• This is a rather big change.

1: Ask JaCoCo to change
We/I can ask JaCoCO to change their logic. They should ignore anonymous classes or lambdas inside of classes marked as @Generated.

Pros:

• The rocker changes are kept minimal.
• Seems like the right thing to me.

Cons:

• Bigger coordination effort since 2 projects are now affected.

2: Abandon the idea
Let's do nothing and chill.

Pros:

• Still better than 3 imo.

Cons:

• My problem is not solved :(

3: Use JSR308 annotations
For java8 let's use JSR308 annotations. Remove the lambdas and replace them with anonymous classes.

Pros:

• ?

Cons:

• Changes in JaCoCo required.
• Only works for java >8.
• Combines the disadvantage of a big change as in 0, with none of it's advantages.

[Serranya]

Actually I am an idiot. JaCoCo already works the way I suggested in 1. Therefor you can ignore my wall of text above.

[Serranya]

@jjlauer have you had a chance to take a look at this PR?

[jjlauer]

Apologize for the delay on my end. This looks great! Nice work.

[jjlauer]

Would you by chance include a few sentences to the README so folks know about this feature?

[Serranya]

Sure. I will add them

[Serranya]

@jjlauer I updated the README

[Serranya]

@jjlauer ping

[Serranya]

@jjlauer ping

[Serranya]

@jjlauer is there anything else I have to do to get this PR accepted?

[jjlauer]

Merged the PR. Also released v1.2.2 for ya.