Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile with Java 11 #95

Closed
Serranya opened this issue Dec 19, 2018 · 3 comments
Closed

Does not compile with Java 11 #95

Serranya opened this issue Dec 19, 2018 · 3 comments

Comments

@Serranya
Copy link
Contributor

The current master branch fails when compiled with Java11:

[...]
[INFO] Reactor Summary for rocker 1.2.1-SNAPSHOT:
[INFO] 
[INFO] rocker ............................................. SUCCESS [  4.852 s]
[INFO] rocker-runtime ..................................... SUCCESS [  6.012 s]
[INFO] rocker-compiler .................................... SUCCESS [  7.292 s]
[INFO] rocker-maven-plugin ................................ SUCCESS [  3.267 s]
[INFO] rocker-gradle-plugin ............................... FAILURE [  5.523 s]
[INFO] rocker-test-java6 .................................. SKIPPED
[INFO] rocker-test-reload ................................. SKIPPED
[INFO] rocker-test-java8 .................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  27.544 s
[INFO] Finished at: 2018-12-19T09:42:43+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.fortasoft:gradle-maven-plugin:1.0.8:invoke (gradle-clean) on project rocker-gradle-plugin: Execution gradle-clean of goal org.fortasoft:gradle-maven-plugin:1.0.8:invoke failed: Could not determine java version from '11.0.1'. -> [Help 1]
[...]
@jjlauer
Copy link
Member

jjlauer commented Jan 19, 2019

Hey @Serranya -- reviewing your PR now. mvn test was running fine -- I finally figured out mvn clean is where that gradle + java 11 issue comes into play. I'm not a gradle expert -- if we bump up the dependency from 3.5 to 5 will that break users from using the gradle plugin running on gradle version < 5?

@Serranya
Copy link
Contributor Author

@jjlauer The PR was made by someone else and not by me. I don't use gradle.

@volyx
Copy link

volyx commented Jan 27, 2019

Is it about this PR #99?

@jjlauer jjlauer closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants