skip symlinks for correct handling of Qt Frameworks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kleuter thanks for your fix, I wrote this to test on my DTK, but at the time we were unable to sign binaries with the version of Xcode that was available in beta, and I haven't tested it post release of apple silicon so I appreciate you taking the time to use it and fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symlinks must be skipped for correct handling of Qt frameworks.
Otherwise it replaces symlinks with original files and the binary couldn't be signed resulting:
bundle format is ambiguous (could be app or framework)Now it works faster of cause too 馃槃