Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support proof of authority transactions #7

Closed
fjarri opened this issue Apr 24, 2022 · 1 comment
Closed

Support proof of authority transactions #7

fjarri opened this issue Apr 24, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
v0.4.2

Comments

@fjarri
Copy link
Collaborator

fjarri commented Apr 24, 2022

I only have a vague idea what it will entail and how to test it. Need to research more.
See ethereum/EIPs#650
@fjarri fjarri added the enhancement New feature or request label Apr 24, 2022
@fjarri fjarri added this to the v0.4.2 milestone May 2, 2022
@fjarri
Copy link
Collaborator Author

fjarri commented Jun 6, 2022

After some review it seems that the only reason web3.py needs geth_poa_middleware being injected is because it renames an extra-long extraData result field that would otherwise not pass the web3.py validation. Since pons doesn't care about that, we don't need to do any extra work.

Closing for now, will reopen if it turns out I was wrong and there is some extra support needed after all.

@fjarri fjarri closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.2
Development

No branches or pull requests
1 participant
@fjarri