Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client sessions #1

Merged
merged 8 commits into from
Mar 24, 2022
Merged

Add client sessions #1

merged 8 commits into from
Mar 24, 2022

Conversation

fjarri
Copy link
Collaborator

@fjarri fjarri commented Mar 21, 2022

  • Added client session support
  • Merged SigningClient into Client (having two types only complicates things; just taking a signer argument instead)
  • Made some improvements to typing

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #1 (79d4d1d) into master (126c3f5) will decrease coverage by 0.10%.
The diff coverage is 84.74%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   77.65%   77.55%   -0.11%     
==========================================
  Files           8        8              
  Lines         470      490      +20     
==========================================
+ Hits          365      380      +15     
- Misses        105      110       +5     
Impacted Files Coverage Δ
pons/types.py 83.17% <0.00%> (ø)
pons/provider.py 51.42% <66.66%> (+10.51%) ⬆️
pons/client.py 91.37% <94.44%> (-0.37%) ⬇️
pons/__init__.py 100.00% <100.00%> (ø)
pons/signer.py 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126c3f5...79d4d1d. Read the comment docs.

@fjarri fjarri merged commit 7de45a4 into master Mar 24, 2022
@fjarri fjarri deleted the session branch March 24, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants