Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corr.show() draws prange in same color as error bars. #175

Closed
EhDings opened this issue May 3, 2023 · 1 comment · Fixed by #178
Closed

Corr.show() draws prange in same color as error bars. #175

EhDings opened this issue May 3, 2023 · 1 comment · Fixed by #178
Assignees
Labels
enhancement New feature or request

Comments

@EhDings
Copy link

EhDings commented May 3, 2023

I was puzzled when I saw that a correlator had a large error in a plot from Corr.show() when print() gave me a small value.
It turns out, the markers for prange are identical to the error bars.
Here, in

        if self.prange:
            ax1.axvline(self.prange[0], 0, 1, ls='-', marker=',')
            ax1.axvline(self.prange[1], 0, 1, ls='-', marker=',')

it would be helpful, if color=... and maybe zorder were defined for axvline.
Nevertheless, I really like the convenience of the Corr class!
Thank you :)

@fjosw
Copy link
Owner

fjosw commented May 3, 2023

Hi @EhDings, thanks for opening this issue. We could maybe default the color of the plateau range indicator to black?! Including zorder also sounds like a good idea. Feel free to open a pull request with these changes if you want or I can also take care of this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants