Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating matching rule for simapro flows with country code in name Flowable, XX #14

Closed
fjuniorr opened this issue Nov 20, 2023 · 2 comments · Fixed by #31
Closed

Creating matching rule for simapro flows with country code in name Flowable, XX #14

fjuniorr opened this issue Nov 20, 2023 · 2 comments · Fixed by #31

Comments

@fjuniorr
Copy link
Owner

Originally posted by @cmutel in #13 (comment)

@fjuniorr
Copy link
Owner Author

@cmutel would a pattern of two uppercase letters not accounting for the actual country codes be too much of a hack?

@cmutel
Copy link
Collaborator

cmutel commented Nov 30, 2023

I think this can work for now, but eventually we will need a whitelist, as there could be other locations which are not only country codes. Don't underestimate the ability of real users to break our systems! But this is fine for now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants