Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setJointAnglesSequenceFullのclearのテストが通らない #913

Closed
mmurooka opened this issue Dec 17, 2015 · 3 comments
Closed

setJointAnglesSequenceFullのclearのテストが通らない #913

mmurooka opened this issue Dec 17, 2015 · 3 comments

Comments

@mmurooka
Copy link
Contributor

#908 (comment) での話のように,
https://github.com/fkanehiro/hrpsys-base/blob/master/sample/SampleRobot/samplerobot_sequence_player.py#L352-L367
のテストが,手元では通るのですが,travisのテストでは失敗します.

travisのテスト失敗ログ: https://s3.amazonaws.com/archive.travis-ci.org/jobs/92443624/log.txt

@snozawa
Copy link
Contributor

snozawa commented Dec 17, 2015

手元で通ってます?
こちらの手元では通らなかった気がします。

@mmurooka
Copy link
Contributor Author

1. demoSetJointAnglesSequenceOfGroup()https://github.com/fkanehiro/hrpsys-base/blob/master/sample/SampleRobot/samplerobot_sequence_player.py#L383 )を呼んだ後だと,
demoSetJointAnglesSequenceFull()https://github.com/fkanehiro/hrpsys-base/blob/master/sample/SampleRobot/samplerobot_sequence_player.py#L384 )でclearのテストが通らないこと.

2. demoSetJointAnglesSequenceFull()だけを呼ぶとclearのテストが通ること

が分かりました.

仕様通りなのかバグなのかはわかりませんが,
demoSetJointAnglesSequenceOfGroup()の最後でjoint groupを削除したところ
1.のケースでも通るようになりましたので,
#914 でPRを切りました.
自分のbranchのtravisのテストで,このPRの変更で通ることを確認した( https://travis-ci.org/mmurooka/hrpsys-base/jobs/97588239 )ので,PRのtravisでも通るはずです.

@mmurooka
Copy link
Contributor Author

#914 で解決しましたのでcloseします.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants