Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mauvais typage de la RequestInterface #30

Open
fkeloks opened this issue Aug 27, 2017 · 0 comments
Open

Mauvais typage de la RequestInterface #30

fkeloks opened this issue Aug 27, 2017 · 0 comments
Assignees
Labels

Comments

@fkeloks
Copy link
Owner

fkeloks commented Aug 27, 2017

Au niveau des fonctions du framework manipulant la requête, le typage de l'interface est mauvais.

En effet, le typage concerne l'interface RequestInterface alors que le framework devrait plutôt typer la ServerRequestInterface.

Exemple de mauvais type dans le BaseController :

/**
 * Returns the request
 * Retourne la requête
 *
 * @return RequestInterface
 */
public function getRequest(): RequestInterface {
    return $this->request;
}

Si le typage est mauvais, les IDE ne proposent pas toutes les méthodes des différentes interfaces.

@fkeloks fkeloks added the bug label Aug 27, 2017
@fkeloks fkeloks self-assigned this Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant