Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I change the wrapper element? #1

Closed
jktravis opened this issue Nov 8, 2016 · 3 comments
Closed

Can I change the wrapper element? #1

jktravis opened this issue Nov 8, 2016 · 3 comments
Assignees

Comments

@jktravis
Copy link
Contributor

jktravis commented Nov 8, 2016

Hi.

I'm trying to use this in a table where the entire <tr> would be the right-click target. The problem is that a <div> is not allowed as a child to a <tbody>.

Is there an easy way to change the wrapper for the menuProvider, or better still, not use one?

@fkhadra
Copy link
Owner

fkhadra commented Nov 8, 2016

Hello,

I don't know why I forgot to allow that. Anyway the I need to review the component.

I'll try to use Children.only instead of a wrapper.
If it doesn't work I'll add the possibility to set the wrapper tag.

I can make a release tonight if you want.

What do you think ?

@jktravis
Copy link
Contributor Author

jktravis commented Nov 8, 2016

Sounds great! Thanks for the quick response!

@fkhadra fkhadra self-assigned this Nov 8, 2016
@fkhadra
Copy link
Owner

fkhadra commented Nov 9, 2016

Hello,

I made a new release ! I extended the api. You can check the README for more details.

@fkhadra fkhadra closed this as completed Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants