Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Config specify swipe to close direction #512

Closed
JakubKoralewski opened this issue Jul 30, 2020 · 5 comments · Fixed by newerton/gobarber-frontend#11 or newerton/gostack-modulo07#17
Labels

Comments

@JakubKoralewski
Copy link

Do you want to request a feature or report a bug?

Feature.

What is the current behavior?

You can only swipe horizontally, left and right to close the toast.

What is the expected behavior?

It would be nice to be able to still have horizontal by default to not make any breaking changes, but still allow to pass an option for the swipe to be vertical.

@jerrybuks
Copy link

can I take on this @fkhadra?

@fkhadra
Copy link
Owner

fkhadra commented Aug 5, 2020

Hey @jerrybuks,

Please do. And don't hesitate if you need some guidance. Thank you !

@jerrybuks
Copy link

Okay, will give it a shot and let send in my questions when I need guidance

@erikujczo
Copy link

@fkhadra @jerrybuks Hey, I would like to take care of this issue.

@denydavy
Copy link
Contributor

I've got a PR for this feature ready to be sent @fkhadra. I use your library in production and I really need this feature ASAP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants