Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TYPO] synchronizeModifications VS synchronizedModifications #39

Closed
Madi-Ji opened this issue Oct 19, 2021 · 2 comments
Closed

[TYPO] synchronizeModifications VS synchronizedModifications #39

Madi-Ji opened this issue Oct 19, 2021 · 2 comments

Comments

@Madi-Ji
Copy link
Contributor

Madi-Ji commented Oct 19, 2021

flagship-php-sdk/src/Visitor.php

Line 356 in 144ffcd

public function synchronizedModifications()

On the documentation the method to update the response of Flagship is synchronizeModifications
The examples mentioned everywhere : (link)

$visitor = Flagship::newVisitor("your_visitor_id")
$visitor->updateContext("isVip", true)
$visitor->synchronizeModifications();

But the method is actually called : synchronizedModifications meaning the "d" letter is a typo :)

It also includes typo in our example within the current repo :)

Thanks team,
Cheers !
@Madi-Ji Madi-Ji mentioned this issue Oct 19, 2021
Merged
@Madi-Ji
Copy link
Contributor Author

Madi-Ji commented Oct 19, 2021

Fix available in #40

@Madi-Ji
Copy link
Contributor Author

Madi-Ji commented Oct 21, 2021

Merge and released
v1.0.2

@Madi-Ji Madi-Ji closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Madi-Ji