New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow controlling when a fixture is rendered #1648
feat: allow controlling when a fixture is rendered #1648
Conversation
I don't think we should rely on userdata for this (preferably we shouldn't rely on userdata for anything, it is a way too fragile pattern). |
(cc: @spydon ) This PR is an initial proposal to filter the rendering of some fixtures. Once settled, I'll update tests, examples and docs. |
Thanks @spydon for having a look. One doesn't need to rely on Is up to the developer how they wish to filter the fixtures. For example, if they don't want to render edge sapes, they can check for it. I've updated the example, since using |
Sorry for the delay on this open PR. Been busy, I will like to prioritise it this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great with some goldens here too :)
You don't have to put flame_forge2d
in the scope that is already derived from what files that are changes, the scope is more if you have a bigger epic that you're working on for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment. Nice tests!
Co-authored-by: Luan Nico <luanpotter27@gmail.com>
Description
Changes
_renderFixtures
torenderFixture
. This keeps the consistency with the other public render methods inBodyComponent
.Introduces new functionalities:
For example, avoiding a fixture to be rendered:
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
Related Issues