Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make _ButtonState public for SpriteButtonComponent #1941

Merged
merged 2 commits into from Sep 27, 2022
Merged

feat: Make _ButtonState public for SpriteButtonComponent #1941

merged 2 commits into from Sep 27, 2022

Conversation

ufrshubham
Copy link
Collaborator

@ufrshubham ufrshubham commented Sep 27, 2022

Description

This PR makes the internal button state of SpriteButtonComponent public. This will make it easier for users to manually change the button state, if needed, by change the value of current. One use case discussed on discord was to make the button appear visually pressed on press on a key.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #1940

@spydon
Copy link
Member

spydon commented Sep 27, 2022

Write the reason for the change in the PR description too. :)

@ufrshubham
Copy link
Collaborator Author

Write the reason for the change in the PR description too. :)

Updated the description 👍🏻

@spydon spydon merged commit e80412c into flame-engine:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose button state for SpriteButtonComponent
2 participants