Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for Forge2dGame #2068

Conversation

ShwetaChauhan18
Copy link
Contributor

  • Working on unit test

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2031

@ShwetaChauhan18 ShwetaChauhan18 force-pushed the fix/unit_test_for_flame_forge2d_#2031 branch from 601cca7 to 78adf8a Compare October 12, 2022 07:54
@spydon spydon merged commit d659b85 into flame-engine:main Oct 13, 2022
@ShwetaChauhan18
Copy link
Contributor Author

@spydon: is anything not proper?? Asking this because '[hacktoberfest-accepted]' flag not added.
If something is not proper then I can make sure it in next PR

@spydon
Copy link
Member

spydon commented Oct 13, 2022

@spydon: is anything not proper?? Asking this because '[hacktoberfest-accepted]' flag not added. If something is not proper then I can make sure it in next PR

I just forgot about it when merging, the PR kept the same high quality as the rest of you PRs, very appreciated! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for flame_forge2d
3 participants