Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Trim whitespace at the end of dialogue lines #2149

Merged
merged 2 commits into from Nov 6, 2022
Merged

feat: Trim whitespace at the end of dialogue lines #2149

merged 2 commits into from Nov 6, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Nov 6, 2022

Description

The whitespace will now be trimmed at the end of expressions like

Line1 #foo
Line2 // bar
Line3\s+

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

@spydon spydon merged commit 9c25e63 into main Nov 6, 2022
@spydon spydon deleted the ps.ws-before-tags branch November 6, 2022 13:56
@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
@st-pasha st-pasha changed the title feat(jenny): Trim whitespace at the end of dialogue lines feat: Trim whitespace at the end of dialogue lines Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@st-pasha @spydon