Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added DialogueView.onNodeFinish event #2229

Merged
merged 17 commits into from Dec 23, 2022
Merged

feat: Added DialogueView.onNodeFinish event #2229

merged 17 commits into from Dec 23, 2022

Conversation

st-pasha
Copy link
Contributor

Description

  • The onNodeFinish event is a counterpart to onNodeStart.
  • This also fixes a small bug where node visit count was not properly incremented if the node was exited via a <<stop>>.
  • The DialogueRunner.runNode() method renamed into startDialogue().

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Related Issues

Closes #2215

@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Dec 21, 2022
@spydon spydon enabled auto-merge (squash) December 22, 2022 23:55
@spydon spydon merged commit 19a1f09 into main Dec 23, 2022
@spydon spydon deleted the ps.on-node-finish branch December 23, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DialogueView.onNodeFinish method
2 participants
@st-pasha @spydon